Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule imminent link state verification on link state changes #83

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

lunkwill42
Copy link
Member

@lunkwill42 lunkwill42 commented Oct 6, 2023

This adds the necessary functionality to the linkstate monitor to replicate what the original Zino code does:

Every time a link state change is detected for a port, a re-verification for that single port is scheduled to run in two minutes.

Closes #79

@lunkwill42 lunkwill42 self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #83 (a30dc9c) into master (7549921) will increase coverage by 0.96%.
Report is 24 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   95.16%   96.12%   +0.96%     
==========================================
  Files          25       30       +5     
  Lines        1404     1828     +424     
==========================================
+ Hits         1336     1757     +421     
- Misses         68       71       +3     
Files Coverage Δ
src/zino/tasks/linkstatetask.py 98.43% <100.00%> (+0.28%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Test results

    3 files      3 suites   57s ⏱️
164 tests 164 ✔️ 0 💤 0
492 runs  490 ✔️ 2 💤 0

Results for commit a30dc9c.

♻️ This comment has been updated with latest results.

@lunkwill42 lunkwill42 force-pushed the feature/linkstate-verify branch 2 times, most recently from 71dcea2 to 66d4184 Compare October 12, 2023 13:28
As per the original Zino code, whenever a port state change is detected,
an extra job to poll that single interface is scheduled.
@lunkwill42 lunkwill42 force-pushed the feature/linkstate-verify branch from 66d4184 to f2c856c Compare October 20, 2023 06:21
@lunkwill42 lunkwill42 marked this pull request as ready for review October 20, 2023 06:22
@lunkwill42 lunkwill42 added the enhancement New feature or request label Oct 20, 2023
src/zino/tasks/linkstatetask.py Outdated Show resolved Hide resolved
src/zino/tasks/linkstatetask.py Show resolved Hide resolved
As pointed out in review.
@lunkwill42 lunkwill42 requested a review from stveit October 20, 2023 13:16
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lunkwill42 lunkwill42 merged commit cad1033 into Uninett:master Oct 20, 2023
9 checks passed
@lunkwill42 lunkwill42 deleted the feature/linkstate-verify branch October 20, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-verify link state changes after two minutes
2 participants